Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix add network form when addMode is true #12833

Merged
merged 3 commits into from
Jan 7, 2025
Merged

fix: fix add network form when addMode is true #12833

merged 3 commits into from
Jan 7, 2025
+63 −32

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jan 2, 2025 •
edited
Loading

Description

fix the add network form when addMode is true

Related issues

Fixes: #12836

Manual testing steps

  1. Go to settings
  2. Go to networks
  3. Go to add networks then custom networls

Screenshots/Recordings

Before

Screenshot 2025-01-02 at 23 40 52

After

Screenshot 2025-01-02 at 23 41 43

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3a3a8fd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/63597ebe-c292-4493-acf2-b7561c7a8811

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb marked this pull request as ready for review January 2, 2025 22:54
@salimtb salimtb requested a review from a team as a code owner January 2, 2025 22:54
NicolasMassart
NicolasMassart reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a link to an issue (even just a twitter post link) in this PR description for context and check the checklist boxes to show you took the items into account?

app/components/Views/Settings/NetworksSettings/NetworkSettings/index.test.tsx Outdated Show resolved Hide resolved
app/components/Views/Settings/NetworksSettings/NetworkSettings/index.test.tsx Outdated Show resolved Hide resolved
app/components/Views/Settings/NetworksSettings/NetworkSettings/index.js Show resolved Hide resolved
@salimtb
Copy link
Contributor Author

salimtb commented Jan 6, 2025

Can you please add a link to an issue (even just a twitter post link) in this PR description for context and check the checklist boxes to show you took the items into account?

done for this one as well

@salimtb salimtb requested a review from NicolasMassart January 6, 2025 13:56
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d09af7d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/10aab382-9fbf-4f12-8b3e-b43a87ddb21b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cce9d89
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b405def5-07b3-4bd0-8653-c12dca0928cc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@salimtb salimtb added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 82d7f87 Jan 7, 2025
41 checks passed
@salimtb salimtb deleted the fix/fix-add-network-form branch January 7, 2025 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@NicolasMassart NicolasMassart Awaiting requested review from NicolasMassart

Assignees
No one assigned
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot add Network from settings
4 participants
@salimtb @NicolasMassart @vinnyhoward @metamaskbot